Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-server): auto complete complex utility values #72

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

cgatian
Copy link
Contributor

@cgatian cgatian commented Feb 22, 2025

Closes #71

📝 Description

Extract token values from utility functions that contain token references.

🎊
fixaroo

Copy link

changeset-bot bot commented Feb 22, 2025

🦋 Changeset detected

Latest commit: 9aeff5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@pandacss/language-server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +154 to +155
const record = ctx.utility.getPropertyValues(utility, (key) => {
return `types:Tokens["${key}"]`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgatian cgatian force-pushed the fix/auto-complete-tokens branch from b28fe8f to 9aeff5e Compare February 22, 2025 16:27
@cgatian cgatian closed this Feb 22, 2025
@cgatian cgatian reopened this Feb 22, 2025
@astahmer astahmer self-requested a review February 24, 2025 14:50
Copy link
Collaborator

@astahmer astahmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks! btw feel free to assign me as a reviewer otherwise I'll not get the PR notifications

@astahmer astahmer merged commit af8cf9c into chakra-ui:main Feb 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolved auto complete is incorrect for utilities
2 participants